Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[Batch Game] Rock, Paper, Scissor by Hack0pz
#2
First thing:
Code:
set loc="C:\Users\%username%\Documents\Hackopz\save.bat"
set loca="C:\Users\%username%\Documents\Hackopz\"
if exist %loca% goto intro
CD "C:\Users\%username%\Documents\Hackopz\"

How do you expect those directories or that file to exist when you don't make a check and create any directory like that?

Also hardcoding "C:\" into the script is always a bad idea.

Code:
if %do%==2 goto begin

This is also a string input so you should be using double quotes around them. Otherwise you've got way too many choices in here in if statements that don't need to exist, and it's calling to a location that will probably never exist on someone else's computer anyway.
Reply


Messages In This Thread
RE: [Batch Game] Rock, Paper, Scissor by Hack0pz - by AceInfinity - 01-20-2012, 03:17 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Pass Generator Batch script AceInfinity 0 903 09-30-2012, 10:17 PM
Last Post: AceInfinity
  Batch tutorial goes here? fanta 3 1,521 05-22-2012, 09:25 PM
Last Post: AceInfinity
  [Batch] Trick - View Environment Variables AceInfinity 0 976 05-05-2012, 07:01 PM
Last Post: AceInfinity
  [Batch] Quick Drive Information Script (Created by AceInfinity) AceInfinity 17 7,248 02-09-2012, 08:10 AM
Last Post: AceInfinity
  [Batch Script] File Binary Data Compare - (Drag & Drop / Command Line Args) AceInfinity 5 3,157 01-14-2012, 05:59 AM
Last Post: ISO

Forum Jump:


Users browsing this thread: 2 Guest(s)