Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Ace's Total Cleaner
#28
It's alright, but a few things

-Some of those entires can point to invalid locations, since you don't check for their existance
-You have way too many ping lines in there
-You don't use quotes to cast input to a definite string value which should be done with all user input, and also using the /i switch to make it case insensitive

Example:
Code:
if %input%==y goto :tree

Becomes:
Code:
if /i %input%=="y" goto tree

You don't need ":" in your goto's, only when you call a block.

And i'm not sure why you do this:
Code:
:tree

start tree.com
start tree.com
start tree.com
start tree.com
start tree.com

You don't even need a block for that really the way I see it, instead of "goto :tree" in the line above the block, delete this entire thing and just use "tree".

Modified line:
Code:
if /i %input%=="y" tree

That's just to show you, but this entire part of your script is useless in my opinion...
Code:
echo Do you want to start tree? (y/n)
set /p input=
if %input%==y tree
if %input%==n goto :a
echo Invelid input. Please type Y if yes or N if no.

:tree

start tree.com
start tree.com
start tree.com
start tree.com
start tree.com
Reply


Messages In This Thread
Ace's Total Cleaner - by AceInfinity - 07-20-2011, 07:01 PM
RE: Ace's Total Cleaner - by AceInfinity - 07-20-2011, 09:45 PM
RE: Ace's Total Cleaner - by Chef - 07-20-2011, 09:50 PM
RE: Ace's Total Cleaner - by AceInfinity - 07-20-2011, 10:07 PM
RE: Ace's Total Cleaner - by Chef - 07-20-2011, 10:09 PM
RE: Ace's Total Cleaner - by AceInfinity - 07-20-2011, 10:11 PM
RE: Ace's Total Cleaner - by AceInfinity - 07-20-2011, 11:53 PM
RE: Ace's Total Cleaner - by AceInfinity - 07-21-2011, 01:45 AM
RE: Ace's Total Cleaner - by BlackChaos - 07-21-2011, 01:51 AM
RE: Ace's Total Cleaner - by AceInfinity - 07-21-2011, 02:12 AM
RE: Ace's Total Cleaner - by AceInfinity - 07-21-2011, 12:35 PM
RE: Ace's Total Cleaner - by Akinova - 07-22-2011, 04:12 AM
RE: Ace's Total Cleaner - by AceInfinity - 07-22-2011, 05:26 AM
RE: Ace's Total Cleaner - by Akinova - 07-22-2011, 05:32 AM
RE: Ace's Total Cleaner - by AceInfinity - 07-22-2011, 05:56 AM
RE: Ace's Total Cleaner - by ₠o™ - 09-10-2011, 05:18 AM
RE: Ace's Total Cleaner - by BreShiE - 09-10-2011, 09:42 AM
RE: Ace's Total Cleaner - by AceInfinity - 09-10-2011, 02:58 PM
RE: Ace's Total Cleaner - by SaNƹ - 09-12-2011, 10:56 AM
RE: Ace's Total Cleaner - by BreShiE - 09-12-2011, 12:06 PM
RE: Ace's Total Cleaner - by AceInfinity - 09-12-2011, 01:26 PM
RE: Ace's Total Cleaner - by ₠o™ - 09-15-2011, 10:05 PM
RE: Ace's Total Cleaner - by Prince - 10-31-2011, 11:35 PM
RE: Ace's Total Cleaner - by prince_of_persia - 12-14-2011, 05:13 AM
RE: Ace's Total Cleaner - by AceInfinity - 12-29-2011, 03:58 AM
RE: Ace's Total Cleaner - by ISO - 01-14-2012, 06:04 AM
RE: Ace's Total Cleaner - by hackopz - 01-14-2012, 10:14 AM
RE: Ace's Total Cleaner - by AceInfinity - 01-14-2012, 10:18 AM
RE: Ace's Total Cleaner - by hackopz - 01-14-2012, 10:22 AM
RE: Ace's Total Cleaner - by AceInfinity - 01-14-2012, 10:29 AM

Possibly Related Threads…
Thread Author Replies Views Last Post
  TLF Diagnostic Tool - Created by Ace [Quick Preview] AceInfinity 0 860 08-26-2011, 06:06 PM
Last Post: AceInfinity
  PowerShell Hotfix List Script - Created by Ace AceInfinity 4 2,178 08-16-2011, 12:09 PM
Last Post: AceInfinity
  [SF Reviews] ATF Cleaner Skill 5 1,993 11-07-2010, 10:05 AM
Last Post: Herm1t

Forum Jump:


Users browsing this thread: 2 Guest(s)